Add async thread pool for generating diskann cache and catch unexpected return. #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cqy123456 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cqy123456
force-pushed
the
1.x-async-pool
branch
from
cd3637e to
1c4a180
Compare
|
|
cqy123456
force-pushed
the
1.x-async-pool
branch
2 times, most recently
from
d83e056 to
dd61b4b
Compare
liliu-z
reviewed
Nov 28, 2023
knowhere/common/ThreadPool.cpp
Outdated
Comment on lines
64
to
75
| std::shared_ptr<ThreadPool> | ||
| ThreadPool::GetGlobalAsyncThreadPool() { | ||
| if (global_thread_pool_size_ == 0) { | ||
| std::lock_guard<std::mutex> lock(global_thread_pool_mutex_); | ||
| if (global_thread_pool_size_ == 0) { | ||
| global_thread_pool_size_ = std::thread::hardware_concurrency(); | ||
| } | ||
| } | ||
| uint32_t async_thread_pool_size = int(std::ceil(global_thread_pool_size_ / 2.0)); | ||
| LOG_KNOWHERE_WARNING_ << "async thread pool size with thread number:" << async_thread_pool_size; | ||
| static auto async_pool = std::make_shared<ThreadPool>(async_thread_pool_size); | ||
| return async_pool; |
There was a problem hiding this comment.
This is not for general purpose, we need to make a static instance in DiskANN instead of here.
cqy123456
force-pushed
the
1.x-async-pool
branch
2 times, most recently
from
19a5de0 to
90c9ada
Compare
…ed return. Signed-off-by: cqy123456 <[email protected]>
cqy123456
force-pushed
the
1.x-async-pool
branch
from
90c9ada to
f6cfc64
Compare
|
/lgtm |
|
/kind improvement |
|
Note: This PR is to solve slow loading time for DiskANN. It lets segments use a shared global threadpool to make cache. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.