Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use knowhere-test refactor #217

Merged

Conversation

cydrain
Copy link
Collaborator

@cydrain cydrain commented Nov 27, 2023

No description provided.

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cydrain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

mergify bot commented Nov 27, 2023

@cydrain 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@cydrain cydrain force-pushed the caiyd_try_knowhere_test_refactor branch from d1e5b99 to 76634e8 Compare November 27, 2023 07:26
@cydrain
Copy link
Collaborator Author

cydrain commented Nov 27, 2023

/hold

@cydrain cydrain force-pushed the caiyd_try_knowhere_test_refactor branch from 76634e8 to 5ea5918 Compare November 27, 2023 07:55
@mergify mergify bot added the ci-passed label Nov 27, 2023
@cydrain cydrain force-pushed the caiyd_try_knowhere_test_refactor branch from 5ea5918 to fba5128 Compare December 1, 2023 03:18
@cydrain cydrain changed the title Try knowhere-test refactor Use knowhere-test refactor Dec 1, 2023
@cydrain
Copy link
Collaborator Author

cydrain commented Dec 1, 2023

/kind improvement

@cydrain
Copy link
Collaborator Author

cydrain commented Dec 1, 2023

/unhold

@cydrain cydrain force-pushed the caiyd_try_knowhere_test_refactor branch from fba5128 to b2c3490 Compare December 1, 2023 04:57
Signed-off-by: Yudong Cai <[email protected]>
@cydrain cydrain force-pushed the caiyd_try_knowhere_test_refactor branch from b2c3490 to b9dee17 Compare December 1, 2023 10:59
@liliu-z
Copy link
Collaborator

liliu-z commented Dec 4, 2023

/lgtm

@sre-ci-robot sre-ci-robot merged commit f15258e into zilliztech:main Dec 4, 2023
4 checks passed
@cydrain cydrain deleted the caiyd_try_knowhere_test_refactor branch December 4, 2023 02:00
cydrain added a commit to cydrain/knowhere that referenced this pull request Dec 5, 2023
  Correct bitset support in pyknowhere (zilliztech#165)
  Add new interface for brute force search and simd test in pyknowhere
  (zilliztech#170)
  Add iterator support to pyknowhere interface. (zilliztech#189)
  Use knowhere-test refactor (zilliztech#217)

Signed-off-by: Yudong Cai <[email protected]>
sre-ci-robot pushed a commit that referenced this pull request Dec 5, 2023
…h: (#248)

Correct bitset support in pyknowhere (#165)
  Add new interface for brute force search and simd test in pyknowhere
  (#170)
  Add iterator support to pyknowhere interface. (#189)
  Use knowhere-test refactor (#217)

Signed-off-by: Yudong Cai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants