Mock register VECTOR_INT8 for all index types #1037
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cydrain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@cydrain 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
cydrain
force-pushed
the
caiyd_977_all_index_support_mock_int8vec
branch
from
c8fad30 to
2d59fc1
Compare
|
/kind improvement |
| @@ -134,12 +138,18 @@ class IndexFactory { | |||
| KNOWHERE_SIMPLE_REGISTER_GLOBAL(name, index_node, bf16, (features | knowhere::feature::BF16), ##__VA_ARGS__); \ | |||
| KNOWHERE_SIMPLE_REGISTER_GLOBAL(name, index_node, fp16, (features | knowhere::feature::FP16), ##__VA_ARGS__); \ | |||
| KNOWHERE_SIMPLE_REGISTER_GLOBAL(name, index_node, fp32, (features | knowhere::feature::FLOAT32), ##__VA_ARGS__); | |||
|
|
|||
| // register vector index supporting ALL_DENSE_FLOAT_TYPE(float32, bf16, fp16) data types, but mocked bf16 and fp16 | |||
| #define KNOWHERE_MOCK_REGISTER_DENSE_FLOAT_ALL_GLOBAL(name, index_node, features, ...) \ | |||
There was a problem hiding this comment.
It is weird to put int8 register function into "KNOWHERE_MOCK_REGISTER_DENSE_FLOAT_ALL_GLOBAL", int8 not a float type.
Signed-off-by: Cai Yudong <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1037 +/- ##
=========================================
+ Coverage 0 73.15% +73.15%
=========================================
Files 0 82 +82
Lines 0 7479 +7479
=========================================
+ Hits 0 5471 +5471
- Misses 0 2008 +2008 |
cydrain
force-pushed
the
caiyd_977_all_index_support_mock_int8vec
branch
from
2d59fc1 to
d4c9f94
Compare
|
/lgtm |
Issue: #977