-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement Next Song retrieval and parsing #35
base: main
Are you sure you want to change the base?
Conversation
This method comes from youtube-music-api to get a list of songs in the UP NEXT tab. - Add getNext() method in YTMusic class - Add NextResult type in types.ts - Create new parser NextParser class
…d and VideoDetailed types and updates the data returned in some methods to reflect these changes. This data can be used for paramater in the getNext() method.
Modifying the SongParser and VideoParser has broken the tests on my end... trying to figure out what the playlistId and params even are in the first place, especially since playlistId does not look like a real YouTube Music playlist id |
i tried to run the test on the main branch and it also failed. i think there is a data change from the API again.
yes you are right, playlistId is not the real id of playlist in yt music but the value of query params my bad, maybe the name needs to be changed so it's not ambiguous. |
Also I added some workflows to make sure the tests work properly so let's try to get this to work! |
…ailed` types to avoid ambiguity
…d ambiguity. part 2 :D
This method comes from youtube-music-api to get a list of songs in the UP NEXT tab.
getNext()
method in YTMusic classNextResult
type intypes.ts
NextParser
classplaylistId
andparams
fields to theSongDetailed
andVideoDetailed
types and updates the data returned in some methods to reflect these changesTest Results