Fix shortening code

yocto · Sep 21, 2022 · 7693304 · 7693304
1 parent 6409730
commit 7693304
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/OpenLocationCode.php b/src/OpenLocationCode.php
@@ -225,6 +225,11 @@ public static function isPaddedByCode($code){
         return (new self($code))->isPadded();
     }
 
+    /**
+     * @param double $referenceLatitude
+     * @param double $referenceLongitude
+     * @return OpenLocationCode
+     */
     public function shorten($referenceLatitude,$referenceLongitude){
         if(!$this->isFull()){
             throw new InvalidArgumentException('shorten() method could only be called on a full code.');
@@ -234,8 +239,7 @@ public function shorten($referenceLatitude,$referenceLongitude){
         }
 
         $codeArea = $this->decode();
-        var_dump($codeArea);
-        $range = max(abs($referenceLatitude - $codeArea->getCenterLatitude()),$referenceLongitude - $codeArea->getCenterLongitude());
+        $range = max(abs($referenceLatitude - $codeArea->getCenterLatitude()),abs($referenceLongitude - $codeArea->getCenterLongitude()));
 
         for($i=4;$i>=1;$i--){
             if($range<(self::computeLatitudePrecision($i*2)*0.3)){

diff --git a/tests/ShorteningTest.php b/tests/ShorteningTest.php
@@ -26,7 +26,6 @@ public function testShortening(){
             if('B'!==$testData->testType && 'S'!==$testData->testType){
                 continue;
             }
-            var_dump($testData);
             $olc = new OpenLocationCode($testData->code);
             $shortened = $olc->shorten($testData->referenceLatitude,$testData->referenceLongitude);
             $this->assertEquals($testData->shortCode,$shortened->getCode(),'Wrong shortening of code '.$testData->code);