fix

yeagerai · Oct 22, 2024 · 58bc5d8 · 58bc5d8
1 parent e998e13
commit 58bc5d8
Showing 1 changed file with 4 additions and 8 deletions.
diff --git a/.github/workflows/test-semgrep.yml b/.github/workflows/test-semgrep.yml
@@ -56,14 +56,10 @@ jobs:
           # Upload file directly to GCS
           gsutil cp semgrep.txt "gs://${GCS_BUCKET}/${FILENAME}"
           
-          # Extract JSON key to a file for signurl
-          echo "${{ secrets.GCP_SA_KEY }}" > key.json
-          
-          # Generate signed URL using the key file
-          SIGNED_URL=$(gsutil signurl -d "${URL_EXPIRATION}" key.json "gs://${GCS_BUCKET}/${FILENAME}" | awk 'NR==2 {print $5}')
-          
-          # Clean up key file
-          rm key.json
+          # Generate signed URL using gcloud storage
+          SIGNED_URL=$(gcloud storage sign-url \
+            "gs://${GCS_BUCKET}/${FILENAME}" \
+            --duration="${URL_EXPIRATION}")
           
           echo "url=${SIGNED_URL}" >> $GITHUB_OUTPUT