Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ".bin" not linked when preparing a git dependency #3723

Merged
merged 1 commit into from
Jun 28, 2017

Conversation

Volune
Copy link
Contributor

@Volune Volune commented Jun 26, 2017

Summary

Fix installation issue reported by @sammarks in #3553

  • I have package-a that depends on package-b (through a git URL as package-b is not published to a registry).
  • package-a and package-b both use Babel (listed in devDependencies in both).
  • package-b's prepare script is: babel --optional runtime src -d dist

When installing the dependencies of package-a, I get an error message: babel: command not found

Test plan

Improved test in __test__/fetchers.js (Updated test dependency Volune/test-js-git-repo@1958040 and Volune/test-js-git-repo@c455e0c)

@Volune Volune force-pushed the fix-bin-script-git-dependency branch from d54ee89 to ed280db Compare June 27, 2017 02:34
@bestander bestander merged commit 08c36fa into yarnpkg:master Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants