Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https://jira.xwiki.org/browse/GLOSSARY-7 #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rfitsyk
Copy link

@rfitsyk rfitsyk commented Jan 18, 2019

Glossary Transformation is case sensitive

Glossary Transformation is case sensitive
@vmassol
Copy link
Member

vmassol commented Jan 18, 2019

Would be nice to have a single PR :)

Note the format for message commits:
https://dev.xwiki.org/xwiki/bin/view/Community/DevelopmentPractices#HRule:AlwaysputaJIRAissuereferenceincommitmessages

@vmassol
Copy link
Member

vmassol commented Jan 18, 2019

I think you did the change directly in GitHub but we need to make sure it passes the build and especially the quality profile, and add some test to prove this. Thanks a lot for starting the fix!

@rfitsyk
Copy link
Author

rfitsyk commented Jan 18, 2019

I'm sorry, it's my first PR :)
Unfortunately, I'm just rolling out the environment (VS Code + plugins, sources), so I did not know how to build.
I'll say even more: I do not have any development experience on Java at all, so I'll go through all the dumb questions :)
But I want to do things more perfectly, despite the difficulties.

@vmassol
Copy link
Member

vmassol commented Jan 18, 2019

Ok, indeed this extension requires some java coding and maven building.

But it's not too hard (but still not easy for someone to used to java dev). If you want to go forward, here's some crash course:

@vmassol
Copy link
Member

vmassol commented Jan 18, 2019

I think this is good knowledge if you're interested to continue contributing in the future.

If you try and can't make it, I'll spend some time (but not in the coming days, I'm a bit too busy right now) to fix the issue.

@rfitsyk
Copy link
Author

rfitsyk commented Jan 18, 2019

Ok, thanks a lot for support :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants