Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate sqlite3 with migrations #138

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

kinow
Copy link

@kinow kinow commented Jul 17, 2021

WIP, just need to fix the INSERT command for sqlite. For a context on this change, my wife is a personal trainer, and I'm creating a small Vue3+FastAPI local app for her to run on her computer to automate part of the process to create new routines.

Trying to bootstrap the database with the code in this repo. Found a few typos, so planning to send a PR later 👍 least I can do to pay back for this great repo 👍

Thanks!
Bruno

@kinow kinow changed the title Generate sqlite3 Generate sqlite3 with migrations Jul 18, 2021
@kinow
Copy link
Author

kinow commented Jul 18, 2021

Actually ended up going with sqlite + migrations... I think with a little more work this could be generic enough, so that others could pick a different driver (MySQL, Postgres, Oracle, etc), and just rely on Knex to do its job and create the queries.

Probably brings some problems for users who do not want to run migrations, and instead prefer to have the SQL script... but there may be a way to tell Knex to just create the SQL for the commands, perhaps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant