New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor to ease usage and packaging #32

Merged

zacdezgeo merged 10 commits into main from refactor/python-packaging

Aug 30, 2024

Collaborator

vincentsarago commented Aug 27, 2024

This PR does (a lot):

update CI code
change the overall structure of the python package
switch from pgstac to postgres docker image
update the python code to support both API and APP (FastAPI) usage
add more configuration option for the database connection (for the APP)
update test suite to use postgresql pytest fixture


          refactor to ease usage and packaging

01cecd1

vincentsarago requested a review from zacdezgeo

August 27, 2024 19:11

vincentsarago commented

View reviewed changes

docker-compose.yaml Show resolved Hide resolved

vincentsarago commented

View reviewed changes

space2stats_api/src/pyproject.toml Outdated Show resolved Hide resolved

vincentsarago commented

View reviewed changes

space2stats_api/src/space2stats/__init__.py Show resolved Hide resolved

vincentsarago commented

View reviewed changes

space2stats_api/src/space2stats/__main__.py Show resolved Hide resolved

vincentsarago commented

View reviewed changes

space2stats_api/src/space2stats/app.py Show resolved Hide resolved

vincentsarago commented

View reviewed changes

space2stats_api/src/space2stats/app.py Show resolved Hide resolved

vincentsarago commented

View reviewed changes

space2stats_api/src/space2stats/main.py Show resolved Hide resolved

vincentsarago commented

View reviewed changes

space2stats_api/src/space2stats/main.py Show resolved Hide resolved

vincentsarago commented

View reviewed changes

space2stats_api/src/tests/test_api.py Show resolved Hide resolved

zacdezgeo mentioned this pull request

Refactor unit test strategy from mocking to pytest fixtures #33

Closed

zacdezgeo assigned vincentsarago

zacdezgeo added the enhancement label

zacdezgeo requested changes

View reviewed changes

Collaborator

zacdezgeo left a comment

Thanks Vincent! Seems like a few minor details to finish up that are more superficial. Really appreciate your help. It was cool to learn about a lot of best practices by you adapting the initial design!

.github/workflows/ci.yml Outdated Show resolved Hide resolved

.gitignore Outdated Show resolved Hide resolved

docker-compose.yaml Show resolved Hide resolved

space2stats_api/src/pyproject.toml Outdated Show resolved Hide resolved

space2stats_api/src/space2stats/__init__.py Show resolved Hide resolved

space2stats_api/src/space2stats/__main__.py Show resolved Hide resolved

space2stats_api/src/space2stats/app.py Show resolved Hide resolved

space2stats_api/src/space2stats/db.py Show resolved Hide resolved

space2stats_api/src/space2stats/handler.py Show resolved Hide resolved

space2stats_api/src/tests/test_api.py Show resolved Hide resolved

vincentsarago commented

View reviewed changes

.gitignore Outdated Show resolved Hide resolved

vincentsarago added 4 commits

August 29, 2024 10:05


          Update .gitignore

3d473e7


          add open=True to avoid deprecation

789b2b1


          add compression middleware

9ffe68c


          switch to orjson

66b3054

vincentsarago commented

View reviewed changes

space2stats_api/src/space2stats/app.py Show resolved Hide resolved

zacdezgeo added 4 commits

August 29, 2024 13:49


          Use poetry for dependency management given lambda deployment

f6e4950


          Update CI for poetry dependency management


          Add pre-commit to poetry test dependencies

feb29bf


          Run pip through python

a020120

zacdezgeo mentioned this pull request

Lambda response error with large requests #35

Closed


          Merge pull request #39 from worldbank/lambda-poetry

64e0fc7

Use poetry for dependency management given lambda deployment

zacdezgeo self-requested a review

August 30, 2024 14:51

zacdezgeo approved these changes

View reviewed changes

vincentsarago marked this pull request as ready for review

August 30, 2024 16:15

zacdezgeo merged commit 4b51bb4 into main

2 checks passed

zacdezgeo deleted the refactor/python-packaging branch

August 30, 2024 23:06

zacdezgeo mentioned this pull request

Python Packaging #30

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels