Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add connection pooling #27

Merged
merged 3 commits into from
Aug 14, 2024
Merged

Add connection pooling #27

merged 3 commits into from
Aug 14, 2024

Conversation

zacdezgeo
Copy link
Collaborator

What I Changed

  • Update db_utils.py for connection pooling.
  • Update test_db_utils.py for connection pool mocking.
  • Update test_api.py to mock db_utils functions instead of database connection.

How to test it

  • Run the unittests python -m pytest
  • Run through the demo notebook while running the API locally

Other notes

@zacdezgeo
Add connection pooling
050cb4a 
Update test_db_utils.py for connection pool mocking. Update test_api.py to mock db_utils functions instead of database connection.
@zacdezgeo zacdezgeo added the enhancement New feature or request label Aug 14, 2024
@zacdezgeo zacdezgeo self-assigned this Aug 14, 2024
alukach
alukach approved these changes Aug 14, 2024
View reviewed changes
space2stats_api/src/app/utils/db_utils.py Outdated Show resolved Hide resolved
@zacdezgeo zacdezgeo merged commit 24c8dd7 into main Aug 14, 2024
2 checks passed
@zacdezgeo zacdezgeo deleted the feature/connect-pool branch August 14, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alukach alukach alukach approved these changes

@bitner bitner bitner approved these changes

@vincentsarago vincentsarago Awaiting requested review from vincentsarago

Assignees

@zacdezgeo zacdezgeo

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Database Connection Management with Connection Pooling
3 participants
@zacdezgeo @bitner @alukach