Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 벌크 연산을 이용하지 못 하는 점을 해결합니다-임시 #133

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

miiiinju1
Copy link
Member

🚀 작업 내용

  • bulkSize까지 최대한 채우다가, timeout이 지난다면 일시적으로 bulk insert를 진행하도록 수정했습니다.

📸 이슈 번호

👀 Focus Commits [Optional]

  • 커밋해시: 내용

✍ 궁금한 점

  • 중점적으로 봐줄 내용
  • 변수명 괜찮나요
  • 로직이 좀 더럽나요
  • 가독성이 좀 그런가요?

- bulkSize까지 최대한 채우다가, timeout이 지난다면 일시적으로 bulk insert를 진행하도록 수정했습니다.
@miiiinju1 miiiinju1 self-assigned this Aug 27, 2024
@miiiinju1 miiiinju1 requested review from LuizyHub and tidavid1 August 27, 2024 09:11
Copy link

Risk Level 3 - /home/runner/work/Team5-Guys/Team5-Guys/logbat/src/main/java/info/logbat/domain/log/repository/AsyncLogProcessor.java

  1. The use of logQueue.add(log); in submitLog could lead to an IllegalStateException if the queue is full. Consider using offer instead to avoid exceptions and handle the case where the queue cannot accept more elements.
    logQueue.offer(log);
  2. In the leaderTask method, the List<Log> logs = new ArrayList<>(); line is commented out, which may lead to confusion. Ensure that the code is clean and remove any unnecessary comments or dead code.
  3. The followerExecutor.execute(() -> saveFunction.accept(logs)); line is commented out, which may indicate incomplete functionality. Ensure that this line is properly implemented to avoid losing logs during processing.

🛠️🔍⚠️


Powered by Code Review GPT

Copy link
Member

@LuizyHub LuizyHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

사이즈를 확인하며 Busy watiting 해서 원하는 로직대로 개선된점 잘 확인했습니다!

@miiiinju1 miiiinju1 changed the title fix: 벌크 연산을 이용하지 못 하는 점을 해결합니다. fix: 벌크 연산을 이용하지 못 하는 점을 해결합니다-임시 Aug 27, 2024
Copy link
Member

@tidavid1 tidavid1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@LuizyHub LuizyHub merged commit 52f471d into dev Aug 27, 2024
1 check passed
@LuizyHub LuizyHub deleted the fix/#132 branch August 27, 2024 10:52
LuizyHub pushed a commit that referenced this pull request Aug 29, 2024
- bulkSize까지 최대한 채우다가, timeout이 지난다면 일시적으로 bulk insert를 진행하도록 수정했습니다.
LuizyHub pushed a commit that referenced this pull request Aug 29, 2024
- bulkSize까지 최대한 채우다가, timeout이 지난다면 일시적으로 bulk insert를 진행하도록 수정했습니다.
LuizyHub pushed a commit that referenced this pull request Aug 29, 2024
- bulkSize까지 최대한 채우다가, timeout이 지난다면 일시적으로 bulk insert를 진행하도록 수정했습니다.
LuizyHub pushed a commit that referenced this pull request Aug 29, 2024
- bulkSize까지 최대한 채우다가, timeout이 지난다면 일시적으로 bulk insert를 진행하도록 수정했습니다.
LuizyHub pushed a commit that referenced this pull request Aug 29, 2024
- bulkSize까지 최대한 채우다가, timeout이 지난다면 일시적으로 bulk insert를 진행하도록 수정했습니다.
LuizyHub pushed a commit that referenced this pull request Aug 29, 2024
- bulkSize까지 최대한 채우다가, timeout이 지난다면 일시적으로 bulk insert를 진행하도록 수정했습니다.
LuizyHub pushed a commit that referenced this pull request Aug 29, 2024
- bulkSize까지 최대한 채우다가, timeout이 지난다면 일시적으로 bulk insert를 진행하도록 수정했습니다.
LuizyHub pushed a commit that referenced this pull request Aug 29, 2024
- bulkSize까지 최대한 채우다가, timeout이 지난다면 일시적으로 bulk insert를 진행하도록 수정했습니다.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants