feat: wasmbus Policy / Config / Secrets Services #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucas Fontes <[email protected]>
lxfontes
force-pushed
the
lxfontes/policy-config
branch
from
af7aa29 to
9ee1883
Compare
Signed-off-by: Lucas Fontes <[email protected]>
Signed-off-by: Lucas Fontes <[email protected]>
|
hold on I will bring the secrets service over too real quick |
Comment on lines
+105
to
+106
| // NOTE(lxf): this covers components but not providers. wut?!? | ||
| Target InvocationTarget `json:"target"` |
There was a problem hiding this comment.
By covers, do you mean that this isn't present when providers call components? Or that you can't actually use this to call a provider
There was a problem hiding this comment.
I couldnt find any mention to providers related to Policy, and the InvocationTarget struct doesn't include any provider info.
it's unclear if this is by design or if we missed providers here.
Signed-off-by: Lucas Fontes <[email protected]>
lxfontes
changed the title
Signed-off-by: Lucas Fontes <[email protected]>
|
secrets are in! good to review 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing Policy & Config services: