-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type field to "ScriptEvaluateResult" for "success" or "exception" #340
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with type: "success"
fbd4ead
to
827fa68
Compare
Filed https://bugzilla.mozilla.org/show_bug.cgi?id=1803599 for updating the webdriver bidi client and tests. |
The Browser Testing and Tools Working Group just discussed The full IRC log of that discussion<jgraham> topic: https://github.com//pull/109<jgraham> github: https://github.com//pull/109 <jgraham> ack JimEvans <AlexRudenko1> Jim Evans: added 109 to the list. Was there any movement on this PR? <AlexRudenko1> jgraham (IRC): the last status was that this PR was fine approx. But I wanted to land HTML changes. <AlexRudenko1> jgraham (IRC): and the last person to look at this was foolip (IRC) but he left <foolip> I can react on chat, possibly <sadym> q+ <AlexRudenko1> jgraham (IRC): have to rewrite the HTML part of this PR and land it <jgraham> ack sadym <AlexRudenko1> sadym (IRC): WPT tests are missing for the PR <AlexRudenko1> jgraham (IRC): would also need to add tests <AlexRudenko1> jgraham (IRC): is it something that is blocking? <AlexRudenko1> Jim Evans: no just trying to clean up <whimboo> https://github.com//pull/340 <AlexRudenko1> whimboo: filed a PR to add the type field <jgraham> github: https://github.com//pull/340 <AlexRudenko1> whimboo: if it looks okay I can make the remaining changes |
@sadym-chromium given that changing the behavior of the webdriver bidi client for wdspec tests to correctly check for that type field would break all of the evaluation tests for Chrome do you think that you could add that field relatively soon, and we are going to land the test changes when that change hit the beta channel? Or what would be your suggestion? |
That's a good idea to land the implementation before the WPT. Let me do that. |
@sadym-chromium I've landed the support for the |
Fixes #339.
This change needs an update of the wpt tests that I can work on if the change is fine.
Preview | Diff