Adding Revision history section #2224
Conversation
index.bs
Outdated
|
|
||
| This section contains the substantive changes that have been made to this specification over time. | ||
|
|
||
| ## Changes since Web Authentication Level 2 [[webauthn-2-20210408]] {#changes-since-l2} |
There was a problem hiding this comment.
Missing ## here causes the title to render as 18.1. Changes since Web Authentication Level 2 [webauthn-2-20210408] {#changes-since-l2}.
| ## Changes since Web Authentication Level 2 [[webauthn-2-20210408]] {#changes-since-l2} | |
| ## Changes since Web Authentication Level 2 [[webauthn-2-20210408]] ## {#changes-since-l2} |
There was a problem hiding this comment.
Also, even with this change the title is rendered as 18.1. Changes since Web Authentication Level 2 [webauthn-2-20210408]. The [webauthn-2-20210408] looks quite awkward to me, especially in the table of contents. Should we move the link into the section body or maybe fold the hyperlink into the "Web Authentication Level 2" text?
There was a problem hiding this comment.
@emlun thank you. Ok to move on the link section (I was reusing the piece of code from another part of the spec)
There was a problem hiding this comment.
Ok! Hm, it occurred to me now that the title "changes since level 2" may become awkward once we release L4. Would "Changes in Web Authentication Level 3" be a suitable title? Is there a process document describing what this section should look like?
index.bs
Outdated
| - Conditional mediation for get: [[#sctn-getAssertion]] | ||
| - Conditional mediation for create: [[#sctn-createCredential]] | ||
| - Added topOrigin: [[#dictionary-client-data]] | ||
| - Create operations in an iframe: [[#sctn-createCredential]] |
There was a problem hiding this comment.
I reckon this should also reference section §5.10. Using Web Authentication within iframe elements; see also #2229
There was a problem hiding this comment.
This would be covered by meta-PR #2230.
There was a problem hiding this comment.
Section 5.10. Using Web Authentication within iframe elements existed as-is in Level 2, so it's not a change. Therefore I don't think it should be added to this list.
There was a problem hiding this comment.
As is right now, yes, but as noted in issue #2229 this section needs to be updated to reflect that create() is now also allowed in cross-origin iframes (and requires the respective feature policy).
There was a problem hiding this comment.
PR #2231 would make the aforementioned update.
Co-authored-by: Emil Lundberg <[email protected]>
|
We should add the |
Proposed changes from review of PR 2224
| ## Changes since Web Authentication Level 2 [[webauthn-2-20210408]] ## {#changes-since-l2} | ||
|
|
There was a problem hiding this comment.
Proposing change as discussed in #2224 (comment):
| ## Changes since Web Authentication Level 2 [[webauthn-2-20210408]] ## {#changes-since-l2} | |
| ## Changes in Web Authentication Level 3 ## {#changes-l3} | |
| The following changes were made between Web Authentication Level 2 [[webauthn-2-20210408]] and Level 3. | |
Add more to L3 revision history
adding revision history section
Closes: #2223
Preview | Diff