Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore[ci]: upload code coverage once #4452

Open
wants to merge 54 commits into
base: master
Choose a base branch
from

Conversation

tserg
Copy link
Collaborator

@tserg tserg commented Jan 17, 2025

What I did

Consolidate code coverage files and upload it once.

How I did it

How to verify it

Commit message

``
chore[ci]: upload code coverage once

This commit updates the CI to append code coverage to a
single file and make a single upload at the end of all test
runs.


### Description for the changelog

### Cute Animal Picture

![Put a link to a cute animal picture inside the parenthesis-->](https://encrypted-tbn0.gstatic.com/images?q=tbn:ANd9GcRgJ3cioNlT_vjx1iffqo3KrCBWwys_hC-D9w&s)

Copy link

codecov bot commented Jan 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.00%. Comparing base (c208b95) to head (3c286ed).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4452      +/-   ##
==========================================
- Coverage   92.01%   92.00%   -0.02%     
==========================================
  Files         119      119              
  Lines       16692    16692              
  Branches     2805     2805              
==========================================
- Hits        15359    15357       -2     
- Misses        915      917       +2     
  Partials      418      418              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tserg
Copy link
Collaborator Author

tserg commented Jan 19, 2025

I haven't been able to figure this out. In order to do coverage combine, we need the raw .coverage data file to be unique per run. This would require the parallel flag in coverage to be set to be true. Since the pytest-cov plugin overrides the parallel flag, we need to rely on the coverage package directly. However, there is still an issue of combining duplicate data - I tried doing combine for the fuzzing run only but it gives the same error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants