Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat[lang]: allow hex literals for unsigned integer types #4380

Closed
wants to merge 5 commits into from
Closed

feat[lang]: allow hex literals for unsigned integer types #4380

wants to merge 5 commits into from

Conversation

tserg
Copy link
Collaborator

@tserg tserg commented Nov 28, 2024

What I did

Resolves #4344.

How I did it

How to verify it

Commit message

feat[lang]: allow hex literals for unsigned integer types

This commit allows hex literals to be used as unsigned
integers. This is enabled by passing constant nodes to 
`compare_type()` for type-checking, and checking for hex
literals if the expected type is an unsigned integer type.

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 28, 2024
View reviewed changes
tests/functional/codegen/types/numbers/test_unsigned_ints.py
@@ -222,11 +223,21 @@
return o
"""

def _to_hex_int(v):

Check notice

Code scanning / CodeQL

Unused local variable Note test

Variable _to_hex_int is not used.
@tserg tserg closed this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow use of hex literals for uint types
1 participant
@tserg