-
-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat[venom]: add binop optimizations #4281
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4281 +/- ##
==========================================
+ Coverage 92.01% 92.09% +0.08%
==========================================
Files 119 119
Lines 16692 16931 +239
Branches 2805 2865 +60
==========================================
+ Hits 15359 15593 +234
- Misses 915 919 +4
- Partials 418 419 +1 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Charles Cooper <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very thorough! i reviewed that every single rule introduced in this PR has a corresponding test case. also added variants for some commutative ops.
depend on sccp being run afterward
What I did
Started reimplementing the binary operation optimization and some additional from original pipeline to venom pipeline
How I did it
The optimization are done in the
AlgebraicOptimizationPass
since the types of optimizations nicely slots into the purpose of the pass. Most of the logic is directly taken from the original pipelineHow to verify it
Commit message
Description for the changelog
Cute Animal Picture