feat[ux]: improve hint for events kwarg upgrade

[charles-cooper]

follow-on commit to ebe3c0c. the hint in ebe3c0c is not specific to the user's source code, and it's a bit laborious for the user to match the call-site to the event def. this commit auto-generates the new call expression for the user to use.

What I did

How I did it

How to verify it

try compiling the following file:

from ethereum.ercs import IERC20

def foo():
    log IERC20.Transfer(msg.sender, msg.sender, 123)

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.09%. Comparing base (4d693b7) to head (b42801e).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4275   +/-   ##
=======================================
  Coverage   92.09%   92.09%           
=======================================
  Files         119      119           
  Lines       16931    16933    +2     
  Branches     2865     2865           
=======================================
+ Hits        15593    15595    +2     
  Misses        919      919           
  Partials      419      419           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[charles-cooper]

there's something interesting going on with examples like

log Transfer(msg.sender, msg.sender, 1)  # 1 is only one character long

i guess mark_tokens() marks the wrong start+end position for the ast node.

[charles-cooper]

i'd say the mark_tokens issue is out of scope -- it should be addressed in #4364

[cyberthirst]

let's please add some tests

[cyberthirst]

it seems that not all nodes have the source assigned?

event Foo:
       a: uint256

@external
def foo(a: uint256):
    log Foo(a)

UserWarning: Instantiating events with positional arguments is deprecated as of v0.4.1 and will be disallowed in a future release. Use kwargs instead e.g.:

Foo(a=)

  contract "tests/custom/test.vy:6", function "foo", line 6:8 
       5 def foo(a: uint256):
  ---> 6     log Foo(a)
  ---------------^
       7

  vyper_warn(msg, node)

notice Foo(a=)

[charles-cooper]

it seems that not all nodes have the source assigned?

event Foo:
       a: uint256

@external
def foo(a: uint256):
    log Foo(a)

UserWarning: Instantiating events with positional arguments is deprecated as of v0.4.1 and will be disallowed in a future release. Use kwargs instead e.g.:

Foo(a=)

  contract "tests/custom/test.vy:6", function "foo", line 6:8 
       5 def foo(a: uint256):
  ---> 6     log Foo(a)
  ---------------^
       7

  vyper_warn(msg, node)

notice Foo(a=)

Yea that's what I mentioned here
#4275 (comment)

[cyberthirst]

Yea that's what I mentioned here #4275 (comment)

oh, that wasn't clear to me from the comment, but i didn't run the attached code

in that case can we add 1 xfail test please?

[charles-cooper]

note: waiting on #4364. we should update the logs in the examples directory in this PR as well.

[cyberthirst]

do we need e.g. when we have a concrete recommendation?