feat: reorder folding after semantics pass #3616
Conversation
|
some high-level review:
|
There was a problem hiding this comment.
for the change to infer_arg_types() API, it would be better to not be so generic, but look like:
def infer_arg_types(self, args, expected_return_type = None):
...otherwise it's too difficult to reason about what kind of generic arguments could go into the *args slot.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| self.visit(node.args[0]) | ||
| node._metadata["folded_value"] = node.args[0]._metadata.get("folded_value") | ||
|
|
||
| from vyper.builtins.functions import DISPATCH_TABLE |
Check notice
Code scanning / CodeQL
Cyclic import Note
| @@ -16,6 +16,7 @@ | |||
| ) | |||
| from vyper.semantics.analysis.base import VarInfo | |||
| from vyper.semantics.analysis.levenshtein_utils import get_levenshtein_error_suggestions | |||
| from vyper.semantics.analysis.pre_typecheck import pre_typecheck | |||
Check notice
Code scanning / CodeQL
Cyclic import Note
| from vyper import ast as vy_ast | ||
|
|
||
|
|
||
| def get_folded_value(node: vy_ast.VyperNode) -> Optional[vy_ast.VyperNode]: |
There was a problem hiding this comment.
get_folded_value should probably tag the node with the return value if it doesn't find it, that way it's dynamic programming and we don't revisit nodes in the traversal
There was a problem hiding this comment.
I have moved the tagging of folded_value in a node's metadata into the pre-typecheck visitor pass. get_folded_value is now a simple wrapper to either get a literal node's value or the literal value of the folded_value metadata.
| if all(isinstance(v, vy_ast.NameConstant) for v in values): | ||
| try: | ||
| node._metadata["folded_value"] = node.evaluate(values) | ||
| except UnfoldableNode: |
Check notice
Code scanning / CodeQL
Empty except Note
| right = get_folded_value(node.right) | ||
| try: | ||
| node._metadata["folded_value"] = node.evaluate(left, right) | ||
| except UnfoldableNode: |
Check notice
Code scanning / CodeQL
Empty except Note
What I did
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture