Fix expectErr implementation #81
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Rust `expect_err` method on which this is based has the type `fn expect_err(self,msg: &str) -> E` meaning that it returns the container `Error` type not the `Ok` type. This change corrects the type signature on BaseResult so the package builds. Also adds a missing semicolon in `ErrImpl`.
Tests check that expectErr leaves an `Err` result alone and throws the provided error message for an `Ok` result.
Changes `expect` to `expectErr` in expectErr section of README. I assume this was a copy paste error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request does three things.
expectErrinBaseResultexpectErrtests in the ok and err test files.expectErrinstead ofexpectFixes #74
@vultix is this repo still active?