Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(client): improve client data types #1626

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(client): improve client data types #1626

wants to merge 1 commit into from
+13 −8

Conversation

Mister-Hope
Copy link
Member

@Mister-Hope Mister-Hope commented Jan 17, 2025 •
edited
Loading

Developers should prefer to use useClientData directly if they need multiple composables at one place:

- const frontmatter = usePageFrontmatter()
- const pageData = usePageData()
+ const { fontmatter, pageData } = useClientData()

This PR ensure frontmatter and pageData can be easily typed.

@Mister-Hope Mister-Hope requested a review from meteorlxy January 17, 2025 07:45
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12824782477

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.722%
Totals Coverage Status
Change from base Build 12271244431: 0.0%
Covered Lines: 648
Relevant Lines: 906
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorlxy meteorlxy Awaiting requested review from meteorlxy

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mister-Hope @coveralls