Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Added support for Bun #630

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[feat] Added support for Bun #630

wants to merge 2 commits into from

Conversation

mchao123
Copy link

@mchao123 mchao123 commented Dec 5, 2024

Added support for Bun, added runtime selectors.

This is a tentative change that may require a review of the code.

@cexbrayat
Copy link
Member

@mchao123 Thanks for the PR

@haoqunjiang Is this something we want to support as an option and yet another feature to maintain? Or could we just add a note in the README instead (as, IIUC, this just requires users to use a specific tsconfig file?).

@haoqunjiang
Copy link
Member

@haoqunjiang Is this something we want to support as an option and yet another feature to maintain? Or could we just add a note in the README instead (as, IIUC, this just requires users to use a specific tsconfig file?).

I'm open to add bun support considering it's low-effort. But I don't think we need yet another option to show to every user. User-agent detection should suffice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants