-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add jsconfig.json for base template #102
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GraxMonzo Thanks for the PR!
Have you tried it out? I'm wondering if putting the file in base
won't add it for all types of projects, even the TS ones.
@sodatea Do you have an opinion on adding a |
I'm fine with adding a |
Hey @cexbrayat. Yes I tried it and tried it without the Thank you for your time. |
@GraxMonzo Sorry I wasn't clear: I meant that the file you added is in |
@cexbrayat Pardon me for misreading you. I haven't tested this with another template but I might think this line of code solves this problem https://github.com/vuejs/create-vue/blob/main/index.ts#L455 |
👍 Awesome, so maybe you can remove the baseUrl from the config if it isn't needed and then we'll be able to merge it |
@cexbrayat Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to https://code.visualstudio.com/docs/languages/jsconfig#_examples we need to explicitly exclude node_modules
and dist
here.
Thanks @GraxMonzo ! |
Create-vue doesn't create a
jsconfig.json
file on the first initialization without TS. Addedjsconfig.json
with aliased paths to base template for out of the box VSCode IntelliSense