Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend remove_hooks to remove subsets #1021

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Extend remove_hooks to remove subsets #1021

wants to merge 2 commits into from

Conversation

kylesayrs
Copy link
Collaborator

@kylesayrs kylesayrs commented Dec 31, 2024 •
edited
Loading

Purpose

  • Allow subsets of hooks to be removed
  • Not strictly needed but helps promote code clarity in the case of wanda which adds and removes subsets of hooks at different times.

Postrequisites

Changes

  • Change the datatype of _hooks from List to Set
  • Add handles argument to HooksMixin.remove_hooks

Testing

  • Added test_remove_hooks_parameterized test

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

@kylesayrs
change arg type
2754145 
Signed-off-by: Kyle Sayers <[email protected]>
@kylesayrs kylesayrs changed the title Extend remove_hooks to remove subsets Extend remove_hooks to remove subsets Jan 1, 2025
@kylesayrs kylesayrs mentioned this pull request Jan 1, 2025
Open
@kylesayrs kylesayrs self-assigned this Jan 1, 2025
@kylesayrs kylesayrs mentioned this pull request Jan 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kylesayrs kylesayrs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kylesayrs