Adds the abnormality core system #2065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
probably shouldn't call it a subsystem in the title, as thats kinda taken by things like the SSLobotomyCorp and SSAtmos subsystems, the proper ones |
vampirebat74
changed the title
You're right, and I didn't think about that. My bad |
vampirebat74
force-pushed
the
abnormality_cores
branch
from
a0a5455 to
cc56e4c
Compare
vampirebat74
force-pushed
the
abnormality_cores
branch
2 times, most recently
from
278e940 to
85b6561
Compare
LanceSmites328
requested changes
Apr 24, 2024
code/modules/mob/living/simple_animal/abnormality/abno_cores.dm
Outdated
Show resolved
Hide resolved
code/modules/mob/living/simple_animal/abnormality/abno_cores.dm
Outdated
Show resolved
Hide resolved
code/modules/mob/living/simple_animal/abnormality/abno_cores.dm
Outdated
Show resolved
Hide resolved
vampirebat74
force-pushed
the
abnormality_cores
branch
from
36e42c7 to
b4a15fc
Compare
LanceSmites328
previously approved these changes
Apr 24, 2024
vampirebat74
force-pushed
the
abnormality_cores
branch
2 times, most recently
from
8fbfd13 to
d0e203c
Compare
EgorDinamit
previously approved these changes
Apr 25, 2024
vampirebat74
force-pushed
the
abnormality_cores
branch
3 times, most recently
from
08ffaf0 to
1054edb
Compare
Kitsunemitsu
previously requested changes
May 3, 2024
vampirebat74
force-pushed
the
abnormality_cores
branch
from
1054edb to
6be1495
Compare
This has been corrected |
vampirebat74
force-pushed
the
abnormality_cores
branch
3 times, most recently
from
333e205 to
078d01d
Compare
vampirebat74
force-pushed
the
abnormality_cores
branch
3 times, most recently
from
310e972 to
1190f2e
Compare
vampirebat74
force-pushed
the
abnormality_cores
branch
2 times, most recently
from
74442e0 to
8f397be
Compare
code/modules/mob/living/simple_animal/abnormality/_abnormality.dm
Outdated
Show resolved
Hide resolved
adds abno core icons abno core extractor final changes Apply suggestions from code review Co-authored-by: [̸R̵e̵d̴a̴c̶t̸e̸d̴]̵ <[email protected]> requested changes removes an unneeded comment Adds skin prophet Minor bug Contract and book fixes bug fix fixes a hilarious bug where abnormalities spawned by hallucinations would leave cores behind Fixes a bug with the naked nest qoh core what it says on the tin fixes nobody is RCA fixes removes spontaneous core generation from R corp assault icondiffbot issues dmi changes icondiffbot fix attempt else if changes else if change
vampirebat74
force-pushed
the
abnormality_cores
branch
from
8f397be to
9873f8f
Compare
Coxswain-Navigator
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Abnormality core! Or abnocores for short. This is a system that allows any abnormality spawned by abministrators or other unusual phenomena to reward the players for suppressing it. Specifically, any abnormality that was spawned without being assigned a console will spawn a core at its location after being Destroy()ed. Current rewards in mind would be: forcing the abnormality into an open containment cell, selling the core for cash or other goodies, or extracting E.G.O from the core directly. These may be more involved in alternative gamemodes.
While undecided at the time of writing, this can be globally disabled for alternate gamemodes such as R Corp Assault, where every abnormality could qualify for a core. They have relatively large icons, but have low layers and do not have collision.
Why It's Good For The Game
This simplifies the addition of many new mechanics without being too intrusive on regular gameplay.
2024-04-23.21-20-43.mp4
Changelog
🆑
add: adds the abnormality core subsystem
imageadd: adds default abnormality core icons
code: minor additions to _abnormality.dm and _info.dm
/:cl: