cgen: add codegen for auto free methods for interface type #22555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipensp
changed the title
Delta456
reviewed
Oct 18, 2024
spytheman
reviewed
Oct 21, 2024
| @@ -0,0 +1,7 @@ | |||
| void main__IFoo_free(main__IFoo* it) { | |||
| if (it->_typ == _main__IFoo_main__Foo_index) { main__Foo_free(it->_main__Foo); return; } | |||
There was a problem hiding this comment.
It could also generate it->_main__Foo = NULL; right after the free call, before the return.
That will make use after frees easier to detect, and simplify the work of the mark stage of the GC, if used in combination with -autofree.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #22074