Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add mysql 8.4 docker images #17529

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add mysql 8.4 docker images #17529

wants to merge 1 commit into from
+186 −5

Conversation

L3o-pold
Copy link
Collaborator

@L3o-pold L3o-pold commented Jan 15, 2025 •
edited
Loading

Description

Add MySQL8.4 docker images

Related Issue(s)

Fixes #17519

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Jan 15, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jan 15, 2025
@L3o-pold L3o-pold force-pushed the feature/mysql84-docker-image branch 2 times, most recently from ac13068 to 4a50e03 Compare January 15, 2025 14:07
@L3o-pold L3o-pold changed the title feat: add mysql 8.4 docker image feat: add mysql 8.4 docker images Jan 15, 2025
@github-actions github-actions bot added this to the v22.0.0 milestone Jan 15, 2025
@L3o-pold L3o-pold marked this pull request as ready for review January 15, 2025 14:23
dbussink
dbussink reviewed Jan 15, 2025
View reviewed changes
docker/bootstrap/Dockerfile.mysql84 Outdated
# Install MySQL 8.4
RUN for i in $(seq 1 10); do apt-key adv --no-tty --recv-keys --keyserver keyserver.ubuntu.com 8C718D3B5072E1F5 && break; done && \
for i in $(seq 1 10); do apt-key adv --no-tty --recv-keys --keyserver keyserver.ubuntu.com A8D3785C && break; done && \
add-apt-repository 'deb http://repo.mysql.com/apt/debian/ bullseye mysql-8.4' && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frouioui Do we have any blockers on upgrading to bookworm? We should get things onto that since bullseye is already in the LTS phase.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we would have any blocker. As discussed offline, we should keep the bullseye builds, move to bookworm as the default, and bump MySQL to 8.0.40 so we can use bookworm.

#17539

@L3o-pold L3o-pold force-pushed the feature/mysql84-docker-image branch from 4a50e03 to 9dd14c1 Compare January 15, 2025 16:42
@codecov Codecov
Copy link

codecov bot commented Jan 15, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.69%. Comparing base (db4fca3) to head (54712fa).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
go/tools/go-upgrade/go-upgrade.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #17529   +/-   ##
=======================================
  Coverage   67.68%   67.69%           
=======================================
  Files        1584     1584           
  Lines      254630   254719   +89     
=======================================
+ Hits       172356   172420   +64     
- Misses      82274    82299   +25

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@L3o-pold L3o-pold force-pushed the feature/mysql84-docker-image branch from 9dd14c1 to 3d9e219 Compare January 15, 2025 17:34
GrahamCampbell
GrahamCampbell reviewed Jan 15, 2025
View reviewed changes
docker/bootstrap/README.md
@@ -7,6 +7,7 @@ The `vitess/bootstrap` image comes in different flavors:

* `vitess/bootstrap:common` - dependencies that are common to all flavors
* `vitess/bootstrap:mysql80` - bootstrap image for MySQL 8.0
* `vitess/bootstrap:mysql84` - bootstrap image for MySQL 8.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also have percona84?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK no one in the community has asked for this yet. We should see who is using the percona tags and if they need a 84 tag.

@L3o-pold
feat: add mysql 8.4 docker image
54712fa 
Signed-off-by: Leopold Jacquot <[email protected]>
@L3o-pold L3o-pold force-pushed the feature/mysql84-docker-image branch from 3d9e219 to 54712fa Compare January 15, 2025 18:14
@frouioui frouioui added Type: CI/Build Component: Docker and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jan 15, 2025
frouioui
frouioui reviewed Jan 15, 2025
View reviewed changes
docker/bootstrap/Dockerfile.mysql84
# Install MySQL 8.4
RUN for i in $(seq 1 10); do apt-key adv --no-tty --recv-keys --keyserver keyserver.ubuntu.com 8C718D3B5072E1F5 && break; done && \
for i in $(seq 1 10); do apt-key adv --no-tty --recv-keys --keyserver keyserver.ubuntu.com A8D3785C && break; done && \
add-apt-repository 'deb http://repo.mysql.com/apt/debian/ bullseye mysql-8.4-lts' && \
Copy link
Member

@frouioui frouioui Jan 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for using mysql-8.4-lts and not mysql-8.4 like in the mysql80 Dockerfile where we don't have -lts?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it seems the way mysql names it in their deb repo :/

frouioui
frouioui reviewed Jan 15, 2025
View reviewed changes
docker/vttestserver/Dockerfile.mysql84
@@ -0,0 +1,59 @@
# Copyright 2021 The Vitess Authors.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
# Copyright 2021 The Vitess Authors.
# Copyright 2025 The Vitess Authors.

frouioui
frouioui reviewed Jan 15, 2025
View reviewed changes
docker/bootstrap/Dockerfile.mysql84
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, the vitess/bootstrap Docker image is only used by two of our CI actions:

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can remove this part if you think it's unnecessary

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually modify bootstrap version increment (BOOTSTRAP_VERSION in the Makefile, and other places) by 1 major version on main when we modify something in this image configuration. Since we are only adding a new image and not modifying existing ones, I think it would be fine to not bump the version in this PR. However, we should document the last entry in CHANGELOG.md of this folder to document the addition of 84.

Copy link
Member

@frouioui frouioui Jan 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can remove this part if you think it's unnecessary

I think it is good to still have it, in the future we may want to use 84 as the default in our tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui frouioui left review comments

@GrahamCampbell GrahamCampbell GrahamCampbell left review comments

@dbussink dbussink dbussink left review comments

@systay systay Awaiting requested review from systay systay is a code owner

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@derekperkins derekperkins Awaiting requested review from derekperkins derekperkins is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Component: Docker Type: CI/Build
Projects
None yet
Milestone
v22.0.0
Development

Successfully merging this pull request may close these issues.

Bug Report: XtraBackup with MySQL 8.4
4 participants
@L3o-pold @dbussink @GrahamCampbell @frouioui