implemented VideoSequenceParser inspired by SDK_Segment_Utils.VideoSequencerParser from original SDK #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…allbacks chore: added Cargo.lock to .gitignore
…allbacks chore: added Cargo.lock to .gitignore
…s.h form original SDK
AdrianEddy
reviewed
Oct 30, 2024
| @@ -1,3 +1,4 @@ | |||
| #![allow(clippy::all)] | |||
There was a problem hiding this comment.
What does this silence? Instead of this, can we fix the clippy lints, or at least silence only specific ones?
AdrianEddy
reviewed
Oct 30, 2024
Comment on lines
+38
to
+43
| log::debug!( | ||
| "Clip Operator: {:?} {:?} {:?}", | ||
| operator_node_type, | ||
| operator_node_hash, | ||
| operator_node_flags | ||
| ); |
There was a problem hiding this comment.
Instead of all these log::debug! calls, I think the parse_clip_operators should return a structute which has all these fields you print here, but the struct impls the Debug trait,. The end-user should just dbg!(parse_clip_operators(...) if they desire, or use the values in other way
There was a problem hiding this comment.
Or return a tuple of the current Ok and namely struct, i.e. Result<(ClipOperatorsMap, ParseClipOperatorStatus), Error>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To simplify the manipulation of VideoSegment in Premiere Pro. Adobe provide the util class, VideoSegmentParser.
This pull request is a WIP re-implementation of this utility in a more agnostic way to let the users freely do what they want with the parsed datas.