Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

completed assigned tasks #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sakshikumar19
Copy link

Screenshot 2023-10-13 120535

@vinfinity7 vinfinity7 self-requested a review October 17, 2023 15:28
@vinfinity7
Copy link
Owner

Great job @sakshikumar19 , well done 👍

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice implementation!
However, I'd encourage you to look into array methods like map, reduce etc, using which these functions can be one-liners.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes bhaiya, understood. I have started STL in C++. Hope to get well versed in it soon.

@@ -26,7 +26,8 @@ function getRectangleArea(width, height) {
* -3, 3 => 0
*/
function getAverage(value1, value2) {
throw new Error("Not implemented");
let average=value1/2+value2/2;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job handling the bit overflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants