Skip to content

Commit

Permalink
fix: noop vtt segment loader handle data (#959)
Browse files Browse the repository at this point in the history
We should noop handleData in vtt segment loader so that any captions which we don't support the type of, such as stpp.ttml.im1t from tears of steal widevine unified streaming do not attempt to append to sourceBuffers and cause a player append error.
  • Loading branch information
brandonocasey authored Sep 25, 2020
1 parent 56a0970 commit d1dcd7b
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/vtt-segment-loader.js
Original file line number Diff line number Diff line change
Expand Up @@ -375,6 +375,10 @@ export default class VTTSegmentLoader extends SegmentLoader {
this.handleAppendsDone_();
}

handleData_() {
// noop as we shouldn't be getting video/audio data captions
// that we do not support here.
}
updateTimingInfoEnd_() {
// noop
}
Expand Down

0 comments on commit d1dcd7b

Please sign in to comment.