Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Region Description as Label and Tooltip #369

Merged

Conversation

ducku
Copy link
Collaborator

@ducku ducku commented Nov 26, 2023

Closes #361

Copy link
Member

@adamnovak adamnovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's definitely helpful to have a screenshot to review PRs like this.

Screenshot 2023-11-28 at 10 18 33

I think having the region description show up in a tooltip like this is a pretty good idea, assuming it doesn't totally confuse touch screens and screen readers. But I don't think we want to use the description as the displayed field name for the region field.

If we really want it displayed persistently on the page, we should find a different place to put it. And if we do display it persistently on the page, then we don't need the tooltip.

Screenshot 2023-11-28 at 10 31 40

Can we do something about the behavior here where, if you're using tab to focus on the field, the tooltip pops up over the dropdown and you can't see the first item? We might not want to let the tooltip and the dropdown be open at the same time if they need to use the same part of the screen.

@ducku
Copy link
Collaborator Author

ducku commented Dec 2, 2023

Changed tooltip position to no longer block dropdown, reverted label to "Region".

Region_Desc

@adamnovak adamnovak merged commit e70b93c into vgteam:master Dec 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get the region description to be visible on the page when looking at the region
2 participants