Prepare for MQTT5 changes #168
Conversation
|
ping us @paul-lysak when we can help you on the PR |
This one is complete, let me know if you'd like to have something changed. It just wouldn't compile until vert-x3/vertx-dependencies#49 is merged. |
|
ok
…On Tue, Sep 15, 2020 at 8:53 AM Paul Lysak ***@***.***> wrote:
ping us @paul-lysak <https://github.com/paul-lysak> when we can help you
on the PR
This one is complete, let me know if you'd like to have something changed.
It just wouldn't compile until vert-x3/vertx-dependencies#49
<vert-x3/vertx-dependencies#49> is merged.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#168 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABXDCWTMCJBAJSJ53RIIEDSF4FQJANCNFSM4RE7KC2A>
.
|
|
@paul-lysak we are still waiting to update to Netty 4.1.52.Final for this contribution, currently this is blocked because vertx-grpc relies on a different version of Netty that cannot be coerced to 4.1.52.Final |
|
@paul-lysak Netty 4.1.52.Final has been merged in master |
|
@paul-lysak can you rebase this branch on master so it will use the new GitHub action based CI ? |
Done |
|
nice, CI is running now |
|
@paul-lysak do you mind rebasing again onto the latest master ? we upgraded to Netty 4.1.58.Final (because 4.1.52.Final has some issues) and I had to fix a few things in order for implementation and tests to work |
Sure, just rebased |
|
alright CI pass so we are good. |
Adapt for Netty
4.1.52.Finalin order to unlock the work on MQTT5 (#161).Depends on vert-x3/vertx-dependencies#49.