Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: move issue tests to separated package #156

Merged
merged 1 commit into from
Jun 7, 2020

Conversation

mincong-h
Copy link
Member

@mincong-h mincong-h commented Jun 7, 2020

⚠️ Please review #155 first

Move all the regression tests (issue tests) to package io.vavr.jackson.issues to have a better separation. Also, rename existing tests to be Issue{id}Test. Only the last commit is relevant.

@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2020

Codecov Report

Merging #156 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #156   +/-   ##
=========================================
  Coverage     93.21%   93.21%           
  Complexity      323      323           
=========================================
  Files            47       47           
  Lines           752      752           
  Branches        168      168           
=========================================
  Hits            701      701           
  Misses           22       22           
  Partials         29       29           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cea184d...e8d4bd9. Read the comment docs.

@mincong-h
Copy link
Member Author

@mincong-h mincong-h merged commit 0b6eec8 into vavr-io:master Jun 7, 2020
@mincong-h mincong-h deleted the issue-tests branch June 7, 2020 14:07
@mincong-h mincong-h added this to the v1.0.0-alpha-3 milestone Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants