Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Fluent model encoding for SQLKit and several Sendable warnings #624

Merged
merged 4 commits into from
Jan 16, 2025

Conversation

gwynne
Copy link
Member

@gwynne gwynne commented Jan 16, 2025

These changes are now available in 1.50.0

Full change list:

  • Require Swift 5.9
  • Resolve several new Sendable-related warnings
  • Fix an issue which caused unpredictable failures when encoding multiple Fluent models for SQLKit queries due to unstable column ordering.
  • Fix NIO API (EmbeddedEventLoop) misuse in tests
  • Disable unfixable flaky test

@gwynne gwynne added the semver-minor Contains new APIs label Jan 16, 2025
@gwynne gwynne requested review from 0xTim, MahdiBM and ptoffy January 16, 2025 09:51
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 24.28%. Comparing base (2cceea2) to head (6378e3e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...s/FluentKit/Concurrency/Database+Concurrency.swift 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #624      +/-   ##
==========================================
- Coverage   24.43%   24.28%   -0.15%     
==========================================
  Files         149      149              
  Lines        9353     9349       -4     
==========================================
- Hits         2285     2270      -15     
- Misses       7068     7079      +11     
Files with missing lines Coverage Δ
Sources/FluentKit/Model/Fields+Codable.swift 81.48% <ø> (-2.39%) ⬇️
Sources/FluentKit/Properties/Relation.swift 51.72% <ø> (ø)
...luentKit/Query/Builder/QueryBuilder+Paginate.swift 75.00% <ø> (ø)
Sources/FluentSQL/SQLDatabase+Model.swift 64.51% <100.00%> (ø)
...s/FluentKit/Concurrency/Database+Concurrency.swift 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

@gwynne gwynne merged commit 260eff9 into main Jan 16, 2025
14 of 15 checks passed
@gwynne gwynne deleted the sendable-and-tests-fixes branch January 16, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-minor Contains new APIs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants