Skip DB execution when all ids for @OptionalParent are nil (#583)

Co-authored-by: Gwynne Raskind <[email protected]>
vapor · Mar 23, 2024 · 5f0938a · 5f0938a
1 parent bb47433
commit 5f0938a
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/Sources/FluentKit/Properties/OptionalParent.swift b/Sources/FluentKit/Properties/OptionalParent.swift
@@ -173,6 +173,12 @@ private struct OptionalParentEagerLoader<From, To>: EagerLoader
         var sets = Dictionary(grouping: models, by: { $0[keyPath: self.relationKey].id })
         let nilParentModels = sets.removeValue(forKey: nil) ?? []
 
+        if sets.isEmpty {
+            // Fetching "To" objects is unnecessary when no models have an id for "To".
+            nilParentModels.forEach { $0[keyPath: self.relationKey].value = .some(.none) }
+            return database.eventLoop.makeSucceededVoidFuture()
+        }
+
         let builder = To.query(on: database).filter(\._$id ~~ Set(sets.keys.compactMap { $0 }))
         if (self.withDeleted) {
             builder.withDeleted()