Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add paused_purpose to INFO CLIENTS #1564

Open
wants to merge 2 commits into
base: unstable
Choose a base branch
from

Conversation

enjoy-binbin
Copy link
Member

@enjoy-binbin enjoy-binbin commented Jan 15, 2025

In #1519, we added paused_actions and paused_timeout_milliseconds,
it would be helpful if we add the paused_purpose since users also
want to know the purpose for the pause.

Currently available options:

  • client_command: trigger by CLIENT PAUSE command.
  • during_shutdown: during shutdown, primary waits the replicas to catch up the offset.
  • during_failover: during failover, primary waits the replica to catch up the offset.
  • none

In valkey-io#1519, we added paused_actions and paused_timeout_milliseconds,
it would be helpful if we add the paused_purpose since users also
want to know the purpose for the pause.

Signed-off-by: Binbin <[email protected]>
@enjoy-binbin enjoy-binbin requested review from soloestoy and a team January 15, 2025 05:29
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 70.95%. Comparing base (2a1a65b) to head (376fd33).
Report is 1 commits behind head on unstable.

Files with missing lines Patch % Lines
src/networking.c 71.42% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1564      +/-   ##
============================================
+ Coverage     70.78%   70.95%   +0.16%     
============================================
  Files           120      120              
  Lines         65046    65077      +31     
============================================
+ Hits          46045    46176     +131     
+ Misses        19001    18901     -100     
Files with missing lines Coverage Δ
src/server.c 87.66% <100.00%> (+0.04%) ⬆️
src/server.h 100.00% <ø> (ø)
src/networking.c 88.40% <71.42%> (+0.04%) ⬆️

... and 14 files with indirect coverage changes

Signed-off-by: Binbin <[email protected]>
@zuiderkwast zuiderkwast added the major-decision-pending Major decision pending by TSC team label Jan 15, 2025
@enjoy-binbin enjoy-binbin requested a review from a team January 16, 2025 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major-decision-pending Major decision pending by TSC team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants