Rename to Valkey for lolwut command

[sarthakaggarwal97]

While trying out few commands in the codebase, I found that upon executing lolwut command on unstable, it still returns Redis Ver. Thought, since we are on unstable, maybe we should remove this?

Let me know if that isn't the case.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.93%. Comparing base (2a1a65b) to head (017d7ab).
Report is 1 commits behind head on unstable.

Files with missing lines	Patch %	Lines
src/lolwut.c	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##           unstable    #1559      +/-   ##
============================================
+ Coverage     70.78%   70.93%   +0.15%     
============================================
  Files           120      120              
  Lines         65046    65060      +14     
============================================
+ Hits          46045    46153     +108     
+ Misses        19001    18907      -94     

Files with missing lines	Coverage Δ
src/lolwut.c	0.00% <0.00%> (ø)

... and 11 files with indirect coverage changes

[zuiderkwast]

Good, but we can avoid hard-coding the name.

(It's weird that we have SERVER_TITLE but we decided to name the version variable VALKEY_VERSION instead of SERVER_VERSION. Maybe there was a reason for that. I don't remember the discussion.)

[zuiderkwast]

Suggested change

	sds rendered = sdsnew("Valkey ver. ");
	sds rendered = sdsnew(SERVER_TITLE " ver. ");

[madolson]

I thought we left this intentionally because it's technically breaking change. Why do we need to change it?

[zuiderkwast]

I guess because seeing "Redis" anywhere sticks out. :D If we want to keep LOLWUT without updates, then we should probably instead return REDIS_VERSION rather than VALKEY_VERSION?

[sarthakaggarwal97]

I guess because seeing "Redis" anywhere sticks out.

Yeah, that's why I raised the change. I wasn't aware that we left this out intentionally.
Do you think that we should take this up in the next major version?

Also, we kinda still use it here as well: https://github.com/valkey-io/valkey/blob/unstable/src/networking.c#L4277

[zuiderkwast]

Oh, I think we missed those security warning logs. We decided during the initial rebranding work that we don't need compatibility for log messages, so I guess it's OK to change them.

I did a quick grep and I found one more occurrence in an error message in script.c: "This Redis command is not allowed from script". My first thought is that I don't think it's risky to change it, but if we think it is, then we could let it depend on the extended-redis-compat configuration.

[sarthakaggarwal97]

We decided during the initial rebranding work that we don't need compatibility for log messages, so I guess it's OK to change them.

I guess I can raise another PR for this, if that's okay. If we decide on changing in the script.c as well, I am happy to do it as well.

[zuiderkwast]

@madolson @ranshid WDYT?

[ranshid]

Trying to understand the issue. AFAIK changing the lolwut can break some clients using it in order to get the current verison.
I agree that providing the unstable version is problematic and we might want to do the same as we did with the info server version (i.e use fixed 7.2.4).

The other issue is that we also have the "Easter eggs" lolwat (which are somewhat broken, for example you cannot enter lolwut which are also presenting the VALKEY_VERSION version and Redis brand (I wonder if these we can be changed).

In anycase I think this should be marked as a breaking change