Escape unix socket group in unit tests

[secwall]

In some cases unix groups could have whitespace and/or \ in them.
One example is my workstation. It's a MacOS in an Active Directory domain. So my user has group LD\Domain Users.
Running make test on unstable and 8.0 branches fails with:

*** FATAL CONFIG FILE ERROR (Version 8.0.2) ***
Reading the configuration file, at line 30
>>> 'unixsocketgroup LD\Domain Users'
wrong number of arguments

I'm not sure if we need to fix this in 8.0. But it seems that it should be fixed in unstable.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.78%. Comparing base (d13aad4) to head (c45bcf1).
Report is 1 commits behind head on unstable.

Additional details and impacted files

@@             Coverage Diff              @@
##           unstable    #1554      +/-   ##
============================================
- Coverage     70.94%   70.78%   -0.16%     
============================================
  Files           120      120              
  Lines         65044    65044              
============================================
- Hits          46143    46039     -104     
- Misses        18901    19005     +104     

see 15 files with indirect coverage changes

[madolson]

Agree, don't think we need to backport it.

[zuiderkwast]

Wouldn't it be more correct to do the escaping inside start_server so it works everywhere and for all options?

(proc start_server is defined in tests/support/server.tcl.)

[secwall]

Probably yes. Do we have a list of all string options that we should escape?
Could we try to escape any string option if we don't have such list?

[zuiderkwast]

I don't know. :) I think some investigation is needed to find out the best solution here. Now it's already merged so let's not worry too much about it.