Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: update issue and PR template #85

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Conversation

aiven-sal
Copy link
Member

I don't like the way our issue and pr templates are now.

WDYT?

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.12%. Comparing base (b424517) to head (c55316d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #85   +/-   ##
=======================================
  Coverage   75.12%   75.12%           
=======================================
  Files         132      132           
  Lines       34400    34400           
=======================================
  Hits        25842    25842           
  Misses       8558     8558           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aiven-sal aiven-sal added the documentation Improvements or additions to documentation label Sep 4, 2024
mkmkme
mkmkme previously approved these changes Sep 5, 2024
Copy link
Collaborator

@mkmkme mkmkme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the fact that things for author only will not be hidden in a comment and not visible as part of an issue/PR description.

Left a couple of questions, otherwise looks good! Thanks!

.github/ISSUE_TEMPLATE/1-bug.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/2-feature.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/2-feature.md Show resolved Hide resolved
Signed-off-by: Salvatore Mesoraca <[email protected]>
Copy link
Collaborator

@mkmkme mkmkme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, thank you!

@aiven-sal aiven-sal merged commit cd24489 into main Sep 6, 2024
74 checks passed
@aiven-sal aiven-sal deleted the aiven-sal/templates branch September 6, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants