Depend on hiredis < 3.0.0 #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
=======================================
Coverage 75.01% 75.01%
=======================================
Files 132 132
Lines 34367 34367
=======================================
Hits 25782 25782
Misses 8585 8585 ☔ View full report in Codecov by Sentry. |
aiven-sal
force-pushed
the
aiven-sal/fixhiredis
branch
from
98f891f to
8f33c27
Compare
hiredis 3.0.0 breaks compatibility with valkey-py. This is just a temporary fix until #32 is ready. Signed-off-by: Salvatore Mesoraca <[email protected]>
aiven-sal
force-pushed
the
aiven-sal/fixhiredis
branch
from
8f33c27 to
500bb82
Compare
ahmedsobeh
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
hiredis 3.0.0 breaks compatibility with valkey-py.
This is just a temporary fix until #32 is ready.