Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RESP3 CI #52

Closed
wants to merge 1 commit into from
Closed

Fix RESP3 CI #52

wants to merge 1 commit into from

Conversation

ahmedsobeh
Copy link
Collaborator

@ahmedsobeh ahmedsobeh commented Jul 12, 2024

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

This PR changes the RESP3 CI tests to run on the same python versions as the other tests. It also removed exclusions that were previously there. It would resolve #44

@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.68%. Comparing base (0109139) to head (9322245).

❗ There is a different number of reports uploaded between BASE (0109139) and HEAD (9322245). Click for more details.

HEAD has 79 uploads less than BASE
Flag BASE (0109139) HEAD (9322245)
97 18
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #52       +/-   ##
===========================================
- Coverage   75.01%   61.68%   -13.34%     
===========================================
  Files         132      132               
  Lines       34367    34367               
===========================================
- Hits        25782    21199     -4583     
- Misses       8585    13168     +4583     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: ahmedsobeh <[email protected]>
@ahmedsobeh ahmedsobeh closed this Jul 13, 2024
@ahmedsobeh ahmedsobeh deleted the issue-44 branch July 13, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RESP3 tests limited scope
2 participants