-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates text in changes file and pr template #37
Conversation
Signed-off-by: Jay Miller <[email protected]>
@ahmedsobeh - it was easier to submit a new PR from a different branch. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
=======================================
Coverage ? 75.02%
=======================================
Files ? 132
Lines ? 34350
Branches ? 0
=======================================
Hits ? 25772
Misses ? 8578
Partials ? 0 ☔ View full report in Codecov by Sentry. |
in issue valkey-io#31 Signed-off-by: Salvatore Mesoraca <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
LGTM! Thanks for submitting it again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm New here.., How do I Perform a Review on this PR?
@aaron-muti-420 you can click on a line you want to add a comment to in the tab called "Files changes". While writing a comment, there will be either "Start a review" and "Add a single comment" buttons. Use whatever feels more natural. |
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Resolves #31 by removing the changes update request in the PR template and adding a comment to the top of the CHANGES file.
This is a cleaned up version of #33