Skip to content

Commit

Permalink
ci: cache docker layers and avoid re-downloading them for each job
Browse files Browse the repository at this point in the history
Sometimes the CI fails because Docker doesn't respond.
It could be because we download many docker images in every
job and we have 58 jobs now.
With this commit, the image layers will be downloaded
during nightly builds and cached.

This seems to cut the CI running time in half from 33~ minutes to 15~.

Signed-off-by: Salvatore Mesoraca <[email protected]>
  • Loading branch information
aiven-sal committed Sep 6, 2024
1 parent cd24489 commit 2a2ace5
Showing 1 changed file with 42 additions and 0 deletions.
42 changes: 42 additions & 0 deletions .github/workflows/integration.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,28 @@ jobs:
pip install -r dev_requirements.txt
invoke linters
populate-cache:
runs-on: ubuntu-latest
timeout-minutes: 60
name: Update docker cache
steps:
- uses: actions/checkout@v4
- name: Cache docker images
id: custom-cache
uses: actions/cache@v3
with:
path: ./custom-cache/
key: custom-cache
- if: ${{ steps.custom-cache.outputs.cache-hit != 'true' || github.event_name == 'schedule' }}
name: Update Cache
run: |
mkdir -p ./custom-cache/
docker compose --profile all build
docker save valkey-py-stunnel:latest valkey-py-cluster:latest valkey/valkey:latest -o ./custom-cache/all.tar
run-tests:
runs-on: ubuntu-latest
needs: [populate-cache]
timeout-minutes: 60
strategy:
max-parallel: 15
Expand All @@ -70,6 +90,17 @@ jobs:
with:
python-version: ${{ matrix.python-version }}
cache: 'pip'

- name: Cache docker images
id: custom-cache
uses: actions/cache@v3
with:
path: ./custom-cache/
fail-on-cache-miss: true
key: custom-cache
- name: Use Cache
run: docker image load -i ./custom-cache/all.tar

- name: run tests
run: |
pip install -U setuptools wheel
Expand Down Expand Up @@ -115,6 +146,17 @@ jobs:
- uses: actions/setup-python@v5
with:
python-version: 3.9

- name: Cache docker images
id: custom-cache
uses: actions/cache@v3
with:
path: ./custom-cache/
fail-on-cache-miss: true
key: custom-cache
- name: Use Cache
run: docker image load -i ./custom-cache/all.tar

- name: Run installed unit tests
run: |
bash .github/workflows/install_and_test.sh ${{ matrix.extension }}
Expand Down

0 comments on commit 2a2ace5

Please sign in to comment.