Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large bloom object handling + Rename to BloomFilterType to BloomObject #37

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

KarthikSubbarao
Copy link
Member

@KarthikSubbarao KarthikSubbarao commented Jan 10, 2025

  1. This PR adds a bloom-memory-usage-limit config that will control the overall memory usage of the bloom object. Any request involving a bloom object creation or scale out that exceeded this limit, will be rejected
  2. Renamed to BloomFilterType to BloomObject

@KarthikSubbarao KarthikSubbarao force-pushed the large branch 4 times, most recently from ee019ed to 87cb4e8 Compare January 10, 2025 21:45
src/bloom/data_type.rs Outdated Show resolved Hide resolved
src/bloom/data_type.rs Outdated Show resolved Hide resolved
src/bloom/data_type.rs Outdated Show resolved Hide resolved
@KarthikSubbarao KarthikSubbarao merged commit 9859dd6 into valkey-io:unstable Jan 11, 2025
6 checks passed
KarthikSubbarao added a commit that referenced this pull request Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants