Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default configuration and related test. #28

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

YueTang-Vanessa
Copy link
Contributor

@YueTang-Vanessa YueTang-Vanessa commented Dec 4, 2024

In this PR:

  • Update default bloom filter configuration
    • capacity: data type: u32 -> i64, default value: 100
    • num_items: data type: u32 -> i64, default value: 0.01
    • max limit of capacity, expansion has been updated.

src/configs.rs Outdated Show resolved Hide resolved
src/configs.rs Outdated Show resolved Hide resolved
src/bloom/utils.rs Outdated Show resolved Hide resolved
@YueTang-Vanessa YueTang-Vanessa force-pushed the unstable branch 2 times, most recently from 70ede8e to 2446e61 Compare December 6, 2024 01:03
@YueTang-Vanessa YueTang-Vanessa changed the title Update default configuration and related test. Fix one flaky test Update default configuration and related test. Dec 6, 2024
@YueTang-Vanessa YueTang-Vanessa force-pushed the unstable branch 3 times, most recently from 613f341 to 5dfe34f Compare December 11, 2024 02:55
@KarthikSubbarao KarthikSubbarao merged commit 4a8af80 into valkey-io:unstable Dec 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants