Support random seed per bloom object by default (configurable) #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KarthikSubbarao
force-pushed
the
fixed-seed
branch
2 times, most recently
from
25fedaf to
1e397d7
Compare
|
Please fix the failed checks |
KarthikSubbarao
force-pushed
the
fixed-seed
branch
from
1e397d7 to
f0e4c53
Compare
zackcam
reviewed
Dec 5, 2024
KarthikSubbarao
commented
Dec 5, 2024
Signed-off-by: Karthik Subbarao <[email protected]>
KarthikSubbarao
force-pushed
the
fixed-seed
branch
from
f0e4c53 to
f126571
Compare
KarthikSubbarao
added a commit
that referenced
this pull request
Dec 5, 2024
Signed-off-by: Karthik Subbarao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support random seed per bloom object by default (configurable) where all filters within the bloom object will use the same sip_keys (for their hash functions) as the first filter within the object which will be randomly generated.
When the new config (bf.bloom-use-random-seed) is disabled, new bloom object creates will use a fixed seed. In this case, the false positives on one bloom object can be reproduced on another bloom object with the same properties due to fixed seed making hashing results deterministic.