Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use % of requests error rather then absolute #138

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

george-angel
Copy link
Member

We can false positive alerts when we have a few errors that are actually
less then 1% of total requests failig. Change the alert to only fire on

10% failed requests.

We can false positive alerts when we have a few errors that are actually
less then 1% of total requests failig. Change the alert to only fire on
>10% failed requests.
@george-angel george-angel requested a review from a team as a code owner November 25, 2024 07:06
@george-angel george-angel merged commit 9206268 into main Nov 25, 2024
2 checks passed
@george-angel george-angel deleted the semaphore-kube-client branch November 25, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants