Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dev-Enablement] match naming convention #747

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

darren-west
Copy link
Contributor

No description provided.

@darren-west darren-west requested a review from a team as a code owner January 6, 2025 09:49
@uw-infra
Copy link

uw-infra commented Jan 6, 2025

Terraform run output for

Cluster: dev-aws
Module: pubsub/kafka-shared-msk-dev-enablement
Path: dev-aws/kafka-shared-msk/dev-enablement
Commit ID: 8aa00f9863bc34a18bb49a74e3b3dc6a9fd1c897
✅ Run Status: Ok, Run Summary: Plan: 1 to add, 0 to change, 1 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  - destroy

Terraform will perform the following actions:

  # module.dev_enablement_pilotcd_worker.kafka_acl.group_acl["dev-enablement.pilotcd.worker"] will be created
  + resource "kafka_acl" "group_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=dev-enablement/pilotcd-worker"
      + id                           = (known after apply)
      + resource_name                = "dev-enablement.pilotcd.worker"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Group"
    }

  # module.dev_enablement_pilotcd_worker.kafka_acl.group_acl["dev_enablement.pilotcd.api"] will be destroyed
  # (because key ["dev_enablement.pilotcd.api"] is not in for_each map)
  - resource "kafka_acl" "group_acl" {
      - acl_host                     = "*" -> null
      - acl_operation                = "Read" -> null
      - acl_permission_type          = "Allow" -> null
      - acl_principal                = "User:CN=dev-enablement/pilotcd-worker" -> null
      - id                           = "User:CN=dev-enablement/pilotcd-worker|*|Read|Allow|Group|dev_enablement.pilotcd.api|Literal" -> null
      - resource_name                = "dev_enablement.pilotcd.api" -> null
      - resource_pattern_type_filter = "Literal" -> null
      - resource_type                = "Group" -> null
    }

Plan: 1 to add, 0 to change, 1 to destroy.

To manually trigger plan again please post @terraform-applier plan dev-aws/kafka-shared-msk/dev-enablement as comment.

@darren-west darren-west merged commit 72ceef0 into main Jan 6, 2025
2 checks passed
@darren-west darren-west deleted the match-naming-convention branch January 6, 2025 09:52
@uw-infra
Copy link

uw-infra commented Jan 6, 2025

Terraform run output for

Cluster: dev-aws
Module: pubsub/kafka-shared-msk-dev-enablement
Path: dev-aws/kafka-shared-msk/dev-enablement
Commit ID: 72ceef0b4bb7ec02274d717e436743d655da1fd6
✅ Run Status: Ok, Run Summary: Apply complete! Resources: 1 added, 0 changed, 1 destroyed
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  - destroy

Terraform will perform the following actions:

  # module.dev_enablement_pilotcd_worker.kafka_acl.group_acl["dev-enablement.pilotcd.worker"] will be created
  + resource "kafka_acl" "group_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=dev-enablement/pilotcd-worker"
      + id                           = (known after apply)
      + resource_name                = "dev-enablement.pilotcd.worker"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Group"
    }

  # module.dev_enablement_pilotcd_worker.kafka_acl.group_acl["dev_enablement.pilotcd.api"] will be destroyed
  # (because key ["dev_enablement.pilotcd.api"] is not in for_each map)
  - resource "kafka_acl" "group_acl" {
      - acl_host                     = "*" -> null
      - acl_operation                = "Read" -> null
      - acl_permission_type          = "Allow" -> null
      - acl_principal                = "User:CN=dev-enablement/pilotcd-worker" -> null
      - id                           = "User:CN=dev-enablement/pilotcd-worker|*|Read|Allow|Group|dev_enablement.pilotcd.api|Literal" -> null
      - resource_name                = "dev_enablement.pilotcd.api" -> null
      - resource_pattern_type_filter = "Literal" -> null
      - resource_type                = "Group" -> null
    }

Plan: 1 to add, 0 to change, 1 to destroy.
module.dev_enablement_pilotcd_worker.kafka_acl.group_acl["dev_enablement.pilotcd.api"]: Destroying... [id=User:CN=dev-enablement/pilotcd-worker|*|Read|Allow|Group|dev_enablement.pilotcd.api|Literal]
module.dev_enablement_pilotcd_worker.kafka_acl.group_acl["dev-enablement.pilotcd.worker"]: Creating...
module.dev_enablement_pilotcd_worker.kafka_acl.group_acl["dev_enablement.pilotcd.api"]: Destruction complete after 0s
module.dev_enablement_pilotcd_worker.kafka_acl.group_acl["dev-enablement.pilotcd.worker"]: Creation complete after 0s [id=User:CN=dev-enablement/pilotcd-worker|*|Read|Allow|Group|dev-enablement.pilotcd.worker|Literal]

Warning: Argument is deprecated

  with provider["registry.terraform.io/mongey/kafka"],
  on __env.tf line 12, in provider "kafka":
  12: provider "kafka" {

This parameter is now deprecated and will be removed in a later release,
please use `client_key` instead.

(and one more similar warning elsewhere)

Apply complete! Resources: 1 added, 0 changed, 1 destroyed.

To manually trigger plan again please post @terraform-applier plan dev-aws/kafka-shared-msk/dev-enablement as comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants