Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup workflows #2
Setup workflows #2
Changes from 52 commits
3918b32
7603c7d
01c7ddd
5a55bbc
caf7a35
357b297
9a75fae
2afaa9e
7cf90b6
4f97b7c
0130477
d98567b
b93d996
d13fb24
bb03840
e697b68
93d8cec
fdcf33b
07f0815
9e6a0d4
e733666
fbb5757
a2dd35f
09e5dd4
cae6d43
45817d2
47b6b1f
aa670c9
7065f54
4d83660
763b2c9
36f89c4
04fc181
fc85dac
91f2c05
3beb5f9
a1d982d
05c077b
c80254c
b1f73cf
116e274
9d59f46
36acdad
862e70a
1b0915f
1fe72e6
cd801db
aba8540
41b2a28
f801af4
c59f497
4db5cf9
59eb530
cf99c3a
cf53ed2
42dfd58
94032ce
6ef0ce3
5518e08
3381cc1
8b71f3f
6c536d1
0cec831
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wondering if this one is necessary since we are also doing reusable workflow in check.yaml (with
insightsengineering/r.pkg.template/.github/workflows/build-check-install.yaml
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I was thinking that
build-check-install
might be too overwhelming/complicated, that's why I thought about a trivial workflow which would still illustrate the idea of reusability and passing/using the inputs.